Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Python-Markdown 3.3.7 during site deployment #3338

Closed
ericseppanen opened this issue Jun 8, 2022 · 1 comment · Fixed by #3939
Closed

Use Python-Markdown 3.3.7 during site deployment #3338

ericseppanen opened this issue Jun 8, 2022 · 1 comment · Fixed by #3939

Comments

@ericseppanen
Copy link
Contributor

ericseppanen commented Jun 8, 2022 •
edited
Loading

We are occasionally bitten by a bug in Python-Markdown <= 3.3.6 that causes lines like this:

* [add `[T]::as_simd(_mut)`](https://github.com/rust-lang/rust/pull/91479)

to be mis-parsed, resulting in a blank line being emitted.

I see that Python-Markdown 3.3.7 has been released, which hopefully has the bugfix. So hopefully we can stop seeing this bug if we can:

  1. Force use of Python-Markdown 3.3.7 when deploying the site (@nellshamrell, is this possible?)
  2. Force use of Python-Markdown 3.3.7 in CI
  3. (optional) remove the workarounds (pointless &nbsp; on the end of the troublesome lines)

See #2781, #3336, ade6ded for places this bit us in the past.
@andrewpollack
Copy link
Member

Looking into this now, and using Python-Markdown 3.3.7 on site deploy is absolutely possible. Making the updates now

@andrewpollack andrewpollack mentioned this issue Jan 6, 2023
Merged
ericseppanen added a commit to ericseppanen/this-week-in-rust that referenced this issue May 12, 2023
@ericseppanen
bump python Markdown package to version 3.3.7
bf0cb07 
The version used to build the site was bumped in rust-lang#3338, but the version
used in CI was not.
@ericseppanen ericseppanen mentioned this issue May 12, 2023
Merged
ericseppanen added a commit that referenced this issue May 12, 2023
@ericseppanen
bump python Markdown package to version 3.3.7
b341e89 
The version used to build the site was bumped in #3338, but the version
used in CI was not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Python-Markdown 3.3.7 andrewpollack/this-week-in-rust
2 participants
@andrewpollack @ericseppanen