-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude draft PRs from triage dashboard #1248
base: master
Are you sure you want to change the base?
Conversation
@@ -52,11 +52,11 @@ pub async fn pulls( | |||
} | |||
|
|||
let mut pulls: Vec<Value> = Vec::new(); | |||
for base_pull in base_pulls.into_iter() { | |||
for base_pull in base_pulls.into_iter().filter(|pull| !pull.draft) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of excluding draft PRs, it might be a better idea to just mark them in gray. WG-triage doesn't triage draft waiting-on-review and waiting-on-author PRs, though it seems we do triage draft blocked PRs. T-clippy might triage draft PRs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think it would make sense to triage them after some time to close them out (basically draft is similar to waiting-on-author I think, in fact I might say that we should just treat it equivalently)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think it would make sense to triage them after some time to close them out
Yeah, they probably should continue to be included.
basically draft is similar to waiting-on-author I think, in fact I might say that we should just treat it equivalently
I wouldn't say they're equivalent, in fact I would say most of the time they are different. For many PRs, waiting-on-author means "the author needs to address reviewer comments or fix conflicts". On the other hand, draft means "this is only partially implemented".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for hiding or indicating as a draft, I'd like to have an option to hide draft (and even S-blocked
) since we don't have to check them frequently and rust-lang/rust's triage queue is quite long. I think something like this would be a good way here (this just hides PRs but we can tweak attributes, e.g., change the color): https://github.com/JohnTitor/triagebot/tree/hide-drafts
I'll split this into two PRs so the date format change can land. |
b31a39d
to
e6952fa
Compare
i think it's good if we can see the draft PRs. They may be draft, but we still need to check them once in a while to ensure there aren't any that are open for a really long time and rotting a lot. |
Is there some kind of indicator we could add to the dashboard that would signal that a PR is draft? |
No description provided.