New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it so that the API URLs are configurable for testing #1764

Merged

jackh726 merged 1 commit into rust-lang:master from ehuss:configurable-url

Jan 22, 2024

Contributor

ehuss commented Jan 22, 2024

This makes it so that the API URLs can be configured via environment variables instead of being hard-coded. The environment variables are:

GITHUB_API_URL: https://api.github.com
GITHUB_GRAPHQL_API_URL: https://api.github.com/graphql
GITHUB_RAW_URL: https://raw.githubusercontent.com
TEAMS_API_URL: https://team-api.infra.rust-lang.org/v1

By itself this isn't particularly useful, it is part of #1698 which adds the ability to mock the endpoints.


          Make it so that the API URLs are configurable for testing

3d5e215

ehuss mentioned this pull request

Create testsuite for GithubClient #1698

Open

jackh726 approved these changes

View reviewed changes

jackh726 merged commit 2f00d26 into rust-lang:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet