Add support for exceptions in non default branch warning #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
force-pushed
the
warn_default_branch-exceptions
branch
from
602f13b to
2d95522
Compare
Urgau
force-pushed
the
warn_default_branch-exceptions
branch
from
2d95522 to
56928c7
Compare
Urgau
commented
Nov 24, 2024
| enable: bool, | ||
| /// List of exceptions that have a different default branch | ||
| #[serde(default)] | ||
| exceptions: Vec<WarnNonDefaultBranchException>, |
There was a problem hiding this comment.
We could also use a HashMap<String, WarnNonDefaultBranchException> where the string would be the branch name, which would permit this and be more consistent with the rest of the configs, but we would losz the "exceptions" field. I'm not sure which one is better.
[assign.warn_non_default_branch]
enable = true
[assign.warn_non_default_branch."beta"]
title = "[beta"
[assign.warn_non_default_branch."stable"]
title = "[stable"
This was referenced Dec 9, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 12, 2024
Use newly added exceptions to non default branch warning cc rust-lang/triagebot#1860 cc `@cuviper` r? `@ehuss`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 12, 2024
Rollup merge of rust-lang#134089 - Urgau:triagebot-exceptions, r=ehuss Use newly added exceptions to non default branch warning cc rust-lang/triagebot#1860 cc `@cuviper` r? `@ehuss`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying exceptions to the global default branch according to the PR title.
This is done to improve the usefulness of the non-default branch warning by making it warn if a PR trying to target the
stablebranch is actually targeting themasterbranch.cc #1852 @cuviper
r? @ehuss