This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Add assert!() and assert_eq!() snippets. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
May 23, 2018
| "assert": { | ||
| "prefix": "assert", | ||
| "body": [ | ||
| "assert!($1)$0" |
There was a problem hiding this comment.
The syntax here and for assert_eq looks wrong, should it be assert!($1, $0)? Also I don't see why it is in this order and not $0, $1.
There was a problem hiding this comment.
Hi @nrc, the $0 tabstop in a snippet actually denotes the final cursor position. Its purpose is to allow users to 'jump out' of the braces on the final 'tab' keypress. It's very convenient because it allows users to add a semicolon at the end without needing to manually move the cursor there.
But it's not only added there for convenience reasons, it's also to have parity with function snippet completions. If you're familiar with them, they all have a final tabstop immediately to the right of the closing brace.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it, RLS relies on Racer for snippet autocompletion (rls/#827). But since snippet autocompletion for macros hasn't been implemented yet (rls/#829), I propose we add two more commonly used macros:
assert!()andassert_eq!()to rls-vscode as a temporary measure.Later on, when macro autocompletion is implemented we should be able to remove these without breaking anything.