Add Send + Sync markers for AlignedVec and Plan. #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlignedVec
is definitely safe to beSend
andSync
as it is mutable only behind uniquemut
pointers.It is harder to reason about
Plan
beingSync
because we don't know if it uses anyUnsafeCell
-like behaviour internally infftw
. However we can be fairly sure it isSend
, as it will be used in situations that rely on using it in different threads (e.g. in a jack realtime thread).Using this crate with
jack
is why I need the changes in this PR to use the library.