-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Pair
interface
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 89.43% 94.21% +4.78%
==========================================
Files 14 6 -8
Lines 511 173 -338
==========================================
- Hits 457 163 -294
+ Misses 54 10 -44
Continue to review full report at Codecov.
|
songww
pushed a commit
to songww/fftw
that referenced
this pull request
Mar 18, 2021
Drop `Pair` interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair interface
Basically
Pair
interface has been introduced to use safe interface in Rust. Original interface of FFTW assumesplan.execute()
form which modify arrays saved inplan
, but this interface is not safe in Rust.However, we has obtained "new array execution" interface in #44, which allow safe interface s.t.
plan.execute(&mut from, &mut to)
.Pair
-based interface.