Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Pair interface #50

Merged
merged 10 commits into from
Jan 17, 2018
Merged

Drop Pair interface #50

merged 10 commits into from
Jan 17, 2018

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Jan 14, 2018

Pair interface

Basically Pair interface has been introduced to use safe interface in Rust. Original interface of FFTW assumes plan.execute() form which modify arrays saved in plan, but this interface is not safe in Rust.
However, we has obtained "new array execution" interface in #44, which allow safe interface s.t. plan.execute(&mut from, &mut to).

  • This PR drops old Pair-based interface.
  • ndarray-based interface is postponed to future PR...

@termoshtt termoshtt added the WIP label Jan 14, 2018
@codecov
Copy link

codecov bot commented Jan 17, 2018

Codecov Report

Merging #50 into master will increase coverage by 4.78%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   89.43%   94.21%   +4.78%     
==========================================
  Files          14        6       -8     
  Lines         511      173     -338     
==========================================
- Hits          457      163     -294     
+ Misses         54       10      -44
Impacted Files Coverage Δ
src/error.rs 0% <0%> (ø) ⬆️
tests/r2c.rs 100% <100%> (ø) ⬆️
src/array.rs 100% <100%> (ø) ⬆️
tests/c2c.rs 100% <100%> (ø) ⬆️
src/plan.rs 94.91% <96%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb4016...d150910. Read the comment docs.

@termoshtt termoshtt removed the WIP label Jan 17, 2018
@termoshtt termoshtt merged commit 5578fc9 into master Jan 17, 2018
@termoshtt termoshtt deleted the drop_pair branch January 17, 2018 15:45
@termoshtt termoshtt added the change Breaking change label Jan 17, 2018
songww pushed a commit to songww/fftw that referenced this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant