Handle non-SIGSTOP signals #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielesvelto
requested changes
Aug 19, 2024
Jake-Shadle
force-pushed
the
handle-non-sigstop-signals
branch
from
6ce1b43 to
11618a4
Compare
gabrielesvelto
approved these changes
Aug 20, 2024
|
LGTM, merge whenever you want. BTW if you want to cut a new release we'll merge it quickly in Firefox as there's a lot of desirable changes that have been made lately. |
|
I can cut a release after lunch. |
|
Thanks a lot 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just implements the code pointed out in #124. I attempted to add a test for this by starting another named thread and sending a SIGHUP to it before spawning the dumper, but I don't think this scenario will ever result in the new code being run.
Resolve: #124