Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the assignment operators #5

Closed
cuviper opened this issue Dec 19, 2017 · 0 comments · Fixed by #12
Closed

Support the assignment operators #5

cuviper opened this issue Dec 19, 2017 · 0 comments · Fixed by #12
Labels
enhancement help wanted

Comments

@cuviper
Copy link
Member

cuviper commented Dec 19, 2017

Would be nice to support AddAssign etc.

cc rust-num/num#173
@cuviper cuviper mentioned this issue Dec 19, 2017
Closed
@c410-f3r c410-f3r mentioned this issue Jan 16, 2018
Merged
bors bot added a commit that referenced this issue Jan 26, 2018
@bors
Merge #12
2b1a4cd 
12: Implement OpAssign for Ratio r=cuviper a=c410-f3r

Copied shamelessly from [#274](rust-num/num#274) but fixes #5.

There is only one problem to solve before anything. Since the implementation doesn't use the `reduce` function, it is possible to exist multiple types of zeros (`0/4`, `0/21`, `0/66`) instead of the default `0/1`, which implies in test errors like `test(_1_2, _NEG1_2, _0);`, therefore, should I rewrite the test suite to be more "zero"  friendly?
@bors bors bot closed this as completed in #12 Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement OpAssign for Ratio c410-f3r/num-rational
1 participant
@cuviper