Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiboot2: builder: allow to add custom tags #170

Merged
merged 2 commits into from
Sep 21, 2023
Merged

multiboot2: builder: allow to add custom tags #170

merged 2 commits into from
Sep 21, 2023

Conversation

phip1611
Copy link
Collaborator

Allow the builder to use custom tags. The challenge here was that TagTrait is not object safe, so having Vec<dyn TagTrait> is not an option.

This closes #168.

Steps to Undraft

The builder allows to set multiple SMBios Tags but the BootInformation only allows to get one.. which one is correct?

@phip1611
Copy link
Collaborator Author

@YtvwlD Hey, could you help me please to figure out what's right? When you added the builder originally, you added the ability to add multiple SmBios tags. However, the boot information only allows to get a single SmBios tag. Which is correct?

@YtvwlD
Copy link
Contributor

YtvwlD commented Jul 18, 2023

I didn't see any limitation to a single tag in the spec. And I thought it would make sense to provide all available SMBIOS (major) versions.
So, from the perspective of a bootloader: If I get both SMBIOS 2 and SMBIOS 3 from the firmware, I can put each of them in a tag and pass both to the operating system.

@phip1611
Copy link
Collaborator Author

I don't have a test setup to reproduce having SMBIOS tags. For simplicity, I restrict it to one tag for now for consistency. Otherwise, I'd need something like a SMBIosTagIterator.

I create a follow-up ticket tho.

@phip1611 phip1611 marked this pull request as ready for review September 21, 2023 09:36
@phip1611 phip1611 changed the title Draft: multiboot2: builder: allow to add custom tags multiboot2: builder: allow to add custom tags Sep 21, 2023
@phip1611 phip1611 enabled auto-merge September 21, 2023 13:15
@phip1611 phip1611 merged commit 6e76ffb into main Sep 21, 2023
28 checks passed
@phip1611 phip1611 deleted the foobar branch September 21, 2023 13:18
@phip1611 phip1611 added this to the multiboot2: v0.19 milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiboot2: builder: Add ability to add custom tags
2 participants