Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi(data-types): allow is_ascii function on Char16 and CStr16 #1008

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

RaitoBezarius
Copy link
Contributor

@RaitoBezarius RaitoBezarius commented Nov 15, 2023

Offers a way to know if a certain UTF-16 string contains only ASCII characters.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

Offers a way to know if a certain UTF-16 string contains only ASCII characters.
@phip1611
Copy link
Contributor

Nice, thanks!

Merged via the queue into rust-osdev:main with commit e85cb82 Nov 15, 2023
12 checks passed
@phip1611
Copy link
Contributor

phip1611 commented Nov 15, 2023

Yikes, @RaitoBezarius . You put the checkmark to Update the changelog (if necessary) but you didn't actually added your changes to the changelog. Please have a look at it the next time :)

It would have been belonged to the "uefi - [Unreleased] / Added" section here: https://github.com/rust-osdev/uefi-rs/blob/main/uefi/CHANGELOG.md

@RaitoBezarius
Copy link
Contributor Author

Yikes, @RaitoBezarius . You put the checkmark to Update the changelog (if necessary) but you didn't actually added your changes to the changelog. Please have a look at it the next time :)

It would have been belonged to the "uefi - [Unreleased] / Added" section here: main/uefi/CHANGELOG.md

Apologies, I read "if necessary" and thought that a simple add of function was not worthy of changelog. I will definitely ensure to do it next time (I hate when people do that too, so… my sincere apologies), may I recommend a PR (which I can send too) to change the template to make explicit what is necessary for a changelog update?

@phip1611
Copy link
Contributor

phip1611 commented Nov 15, 2023

Sure, go ahead. Thanks :)

Please keep it simple, short and precisely.

FYI @nicholasbishop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants