cstr[ing]16: convenience functions #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
str
branch
5 times, most recently
from
eb91c71 to
d877642
Compare
uefi/src/data_types/owned_strs.rs
Outdated
| pub struct CString16(Vec<Char16>); | ||
|
|
||
| impl CString16 { | ||
| /// Creates a new empty string with a null-byte. |
There was a problem hiding this comment.
"null character" rather than null byte, since for a Char16 it's two bytes.
phip1611
force-pushed
the
str
branch
2 times, most recently
from
e93168b to
6796370
Compare
|
I think I addressed all points. Thanks for the feedback. Are we good to go now? |
phip1611
force-pushed
the
str
branch
2 times, most recently
from
3c9d948 to
d04b48f
Compare
nicholasbishop
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #747 I'm about to add a
PathBufstruct as wrapper aroundCString16, akin to the standard library. For this, a lot of convenience functions are missing onCStr16andCString16. This PR adds those.Checklist