-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split JitterRng into a separate crate #685
Conversation
Nice job but writing the impl before any decision is potentially a wasted effort. I appreciate the extra modularisation though. Note if we do use this code: don't forget the copyright boilerplate this time (excepting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rand/utils/ci/script.sh
still needs to be updated to include the new crate.
Looks good, besides the nits!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks! Let's make sure to resolve the discussion in #681 before merging.
If we are going to do this, then I think it should be an optional dependency. |
Then you'll have to publish v0.7, as |
|
#681