atomic_bitmap: support enlarging the bitmap #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russell-islam
requested review from
alexandruag,
bonzini,
jiangliu and
roypat
as code owners
russell-islam
force-pushed
the
muislam/enlarge
branch
from
533eacf to
ef0d35a
Compare
russell-islam
changed the title
russell-islam
force-pushed
the
muislam/enlarge
branch
from
ef0d35a to
9e42a59
Compare
roypat
reviewed
Oct 2, 2024
russell-islam
force-pushed
the
muislam/enlarge
branch
3 times, most recently
from
6496f59 to
beb4b05
Compare
roypat
previously approved these changes
Oct 3, 2024
rbradford
reviewed
Oct 3, 2024
russell-islam
force-pushed
the
muislam/enlarge
branch
2 times, most recently
from
4c6f582 to
88d487c
Compare
|
@roypat @rbradford Please take another look to see the changes make sense now!! |
rbradford
reviewed
Oct 4, 2024
src/bitmap/backend/atomic_bitmap.rs
Outdated
| @@ -117,6 +128,11 @@ impl AtomicBitmap { | |||
| self.size | |||
| } | |||
|
|
|||
| /// Get the size in bytes i.e how many bytes the bitmap can represent, one bit per page sage. | |||
There was a problem hiding this comment.
Typo - last word in this comment?
Keeping the byte_size in the struct gives freedom to the caller to use it for any processing at their end.This field can be used by the caller in case of enlarging the bitmap. Signed-off-by: Muminul Islam <[email protected]>
This patch adds the support the enlarge the atomic bitmap. Some use cases in cloud-Hypervisor needs to enlarge the bitmap on-demand. Signed-off-by: Muminul Islam <[email protected]>
Add one test case to validate the enlarge function of the AtomicBitmap struct. Signed-off-by: Muminul Islam <[email protected]>
russell-islam
force-pushed
the
muislam/enlarge
branch
from
88d487c to
bac5f99
Compare
rbradford
approved these changes
Oct 4, 2024
roypat
approved these changes
Oct 7, 2024
TimePrinciple
pushed a commit
to TimePrinciple/vm-memory
that referenced
this pull request
Oct 7, 2024
To incorporate: - [[rust-vmm#287](rust-vmm#287)] Support for RISC-V 64-bit platform. - [[rust-vmm#299](rust-vmm#299)] atomic_bitmap: support enlarging the bitmap. Signed-off-by: Ruoqing He <[email protected]>
TimePrinciple
pushed a commit
to TimePrinciple/vm-memory
that referenced
this pull request
Oct 9, 2024
To incorporate: - [[rust-vmm#287](rust-vmm#287)] Support for RISC-V 64-bit platform. - [[rust-vmm#299](rust-vmm#299)] atomic_bitmap: support enlarging the bitmap. Signed-off-by: Ruoqing He <[email protected]>
roypat
pushed a commit
that referenced
this pull request
Oct 9, 2024
To incorporate: - [[#287](#287)] Support for RISC-V 64-bit platform. - [[#299](#299)] atomic_bitmap: support enlarging the bitmap. Signed-off-by: Ruoqing He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This patch adds the support the enlarge the atomic bitmap.
Some use cases in cloud-Hypervisor needs to enlarge the bitmap on-demand.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.