feat: Implement ReadVolatile and WriteVolatile for TcpStream #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljrcore
requested review from
alexandruag,
bonzini,
jiangliu and
roypat
as code owners
roypat
reviewed
Oct 24, 2024
Done. Thanks |
roypat
reviewed
Oct 24, 2024
Add implementations of the ReadVolatile and WriteVolatile traits for std::net::TcpStream by extending the impl_read_write_volatile_for_raw_fd! macro. Suggested-by: Patrick Roy <[email protected]> Signed-off-by: Yi Wang <[email protected]> Signed-off-by: Jinrong Liang <[email protected]>
roypat
approved these changes
Oct 28, 2024
rbradford
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementations of the ReadVolatile and WriteVolatile traits for std::net::TcpStream by extending the impl_read_write_volatile_for_raw_fd! macro.