Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
winit
we're currently discussing this, both in rust-windowing/winit#3136 and on Matrix. See also previous discussion in #59, and the related issue in #85.So I've opened this PR to see what it would take to make the handles
Send + Sync
, which would be somewhat possible on macOS, iOS and the web (provided that users uphold the "only use this on the main thread" requirement, which one could argue might be a safety footgun) - though I'm unsure if it's actually safe on the other platforms?In any case we need to do something, because
winit::Window
isSend + Sync
, and it unconditionally implementsHasWindowHandle
, so users could always just send the window to another thread and get a handle from that.Fixes #85 and fixes #147.
TODO: