Make event::VirtualKeyCode::LWin and RWin names more generic.
#2055
Labels
S - enhancement
Wouldn't this be the coolest?
Comments
|
I believe those variants (or rather, their counterparts in the two new key enums) are already being renamed to |
kchibisov
added a commit
that referenced
this issue
May 28, 2023
Overhaul the keyboard API in winit to mimic the W3C specification
to achieve better crossplatform parity. The `KeyboardInput` event
is now uses `KeyEvent` which consists of:
- `physical_key` - a cross platform way to refer to scancodes;
- `logical_key` - keysym value, which shows your key respecting the
layout;
- `text` - the text produced by this keypress;
- `location` - the location of the key on the keyboard;
- `repeat` - whether the key was produced by the repeat.
And also a `platform_specific` field which encapsulates extra
information on desktop platforms, like key without modifiers
and text with all modifiers.
The `Modifiers` were also slightly reworked as in, the information
whether the left or right modifier is pressed is now also exposed
on platforms where it could be queried reliably. The support was
also added for the web and orbital platforms finishing the API
change.
This change made the `OptionAsAlt` API on macOS redundant thus it
was removed all together.
Co-Authored-By: Artúr Kovács <[email protected]>
Co-Authored-By: Kirill Chibisov <[email protected]>
Co-Authored-By: daxpedda <[email protected]>
Fixes: #2631.
Fixes: #2055.
Fixes: #2032.
Fixes: #1904.
Fixes: #1810.
Fixes: #1700.
Fixes: #1443.
Fixes: #1343.
Fixes: #1208.
Fixes: #1151.
Fixes: #812.
Fixes: #600.
Fixes: #361.
Fixes: #343.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, these enum variants are named
LWinandRwin, respectively. However, on MacOS, these key codes map to the Command key. Considering this, and the fact that referring to it as the Windows key is somewhat platform-specific, it might be worth renaming these variants to something more generic (IE:LSuperandRSuper).The text was updated successfully, but these errors were encountered: