Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac: Remove error log when pressing Fn key #3247

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Mac: Remove error log when pressing Fn key #3247

merged 3 commits into from
Nov 28, 2023

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Nov 28, 2023 •
edited
Loading

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@emilk emilk requested a review from madsmtm as a code owner November 28, 2023 13:46
kchibisov
kchibisov requested changes Nov 28, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@emilk @kchibisov
Update CHANGELOG.md
c336667 
Co-authored-by: Kirill Chibisov <[email protected]>
@kchibisov kchibisov added this to the Version 0.29.5 milestone Nov 28, 2023
@kchibisov kchibisov merged commit a7241b3 into rust-windowing:master Nov 28, 2023
50 checks passed
@emilk emilk deleted the emilk/remove-error-log branch December 31, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

@kchibisov kchibisov kchibisov approved these changes

Assignees
No one assigned
Labels
DS - macos
Milestone
Version 0.29.5
Development

Successfully merging this pull request may close these issues.

Pressing Fn key on Macbook logs an error
4 participants
@emilk @madsmtm @kchibisov @daxpedda