Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up for integration tests #3564

Closed
wants to merge 4 commits into from
Closed

Set up for integration tests #3564

wants to merge 4 commits into from

Conversation

notgull
Copy link
Member

@notgull notgull commented Mar 4, 2024 •
edited by madsmtm
Loading

As discussed in our last meeting, adds the bones of an integration test framework to winit.

See #2866.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

notgull added 4 commits March 3, 2024 20:19
@notgull
it: Create the 'gui-test' crate
3f3bf8d 
The 'gui-test' crate is intended to provide a test framework for process
isolated and remote test cases. Like how I intend to test winit.

Signed-off-by: John Nunley <[email protected]>
@notgull
it: Add basic handlers
cfe1e37 
Signed-off-by: John Nunley <[email protected]>
@notgull
it: Add runner and common tests
6ec2035 
Still needs some work, but the idea should be clear.

Signed-off-by: John Nunley <[email protected]>
@notgull
it: Don't capture stdout
5d8645f 
Signed-off-by: John Nunley <[email protected]>
@notgull notgull marked this pull request as ready for review March 5, 2024 05:00
kchibisov
kchibisov requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

rust-windowing/winit-next#3 (review)

@notgull
Copy link
Member Author

notgull commented Mar 10, 2024

I've merged this branch into the new it branch. Other maintainers should open integration testing pull requests against this branch.

@notgull notgull closed this Mar 10, 2024
@notgull notgull deleted the notgull/it branch March 10, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov kchibisov requested changes

@madsmtm madsmtm madsmtm approved these changes

@daxpedda daxpedda Awaiting requested review from daxpedda

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notgull @madsmtm @kchibisov