Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Use doc(no_inline) on unnamed prelude exports #118

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Use doc(no_inline) on unnamed prelude exports #118

merged 1 commit into from
Oct 10, 2019

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Oct 7, 2019

Description

Closes #115

Refs: rust-lang/futures-rs#1662 (comment)

Screenshot:

Before (master):

before

After (this PR):

after

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@taiki-e taiki-e requested a review from yoshuawuyts October 7, 2019 21:45
yoshuawuyts
yoshuawuyts approved these changes Oct 10, 2019
View reviewed changes
Copy link
Collaborator

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- though I'd like to take a moment to note we may want to start winding down work on Runtime and eventually retire the project entirely in favor of recommending people use async-std or tokio.

@yoshuawuyts yoshuawuyts merged commit aa7cc5f into rustasync:master Oct 10, 2019
@taiki-e taiki-e deleted the doc-no-inline branch October 11, 2019 04:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trait _ in docs
2 participants
@taiki-e @yoshuawuyts