Add WebTransport webidl to unstable #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Liamolucko let me know the next steps 😄 |
Liamolucko
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Looks good! I just left one comment about the URL of the WebIDL file being wrong.
I would have asked you to add [Throws] to any functions that can throw, which tells the code generator the function should return a Result, but it turns out that nothing in WebTransport can actually throw anyway, since everything's async and results in a promise rejection or similar instead.
Co-authored-by: Liam Murphy <[email protected]>
|
@Liamolucko change applied, thanks for your review 😄 |
This was referenced Mar 28, 2023
Merged
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added WebTransport webidl definitions to the unstable features.