-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update screeps-game-api to Rust 2018. #161
Conversation
A lot could be done to get rid of the |
Sounds reasonable! I'm good with merging this without all the stuff like Travis seems to be complaining about one more |
I missed that in my
Will have a look. I saw travis' notification too late yesterday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
I have a bunch of nits, but they're mostly about import ordering. rustfmt
's comment formatting also breaks some markdown stuff, but it's at least better than the last time I tried it.
LMK if this seems reasonable? I could also go through and do some of the import order fixes and PR to this branch before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@@ -11,9 +12,10 @@ use { | |||
/// | |||
/// [http://docs.screeps.com/api/#Game.cpu]: http://docs.screeps.com/api/#Game.cpu | |||
pub mod cpu { | |||
use serde::{Deserialize, Serialize}; | |||
use std::collections; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One std::
below serde::
here, but ¯\_(ツ)_/¯
Ran
cargo fix --edition
and added the edition flag inCargo.toml
.