Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generate-pixel and inter-shard-memory features, restrict more CPU functions #507

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

shanemadden
Copy link
Collaborator

@shanemadden shanemadden commented Mar 3, 2024

CPU functions and data related to using CPU unlocks are missing on private servers, and attempting to use the interfaces will cause a panic - they should be behind a feature.

Instead of adding one or two more granular sub-features of mmo, it seemed better to just consolidate generate-pixel and inter-shard-memory down into the mmo feature. If a practical case arises where a private server supports some of the mmo-like interfaces but not all of 'em, it might make sense to re-add that level of granularity, but for now it seems like overkill.

@scottbot95
Copy link
Contributor

Might be worth also adding #[cfg(not(feature="sim"))] to the CPU halt functions Game.cpu.halt() does not exist in the sim.

@tiennou
Copy link

tiennou commented Mar 3, 2024

Might be worth also adding #[cfg(not(feature="sim"))] to the CPU halt functions Game.cpu.halt() does not exist in the sim.

There's a few more. I have Game.map, Game.market and PathFinder.CostMatrix also disabled in the profiler's default list there.

@shanemadden
Copy link
Collaborator Author

Good point on the stuff that's not in sim - I'll make an issue to track getting those added as well!

@shanemadden shanemadden merged commit 4d4146a into rustyscreeps:main Mar 4, 2024
9 checks passed
@shanemadden shanemadden deleted the mmo_feature_cpu branch March 4, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants