Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor string enums to integer representations, add optional snippet optimizations #512

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

shanemadden
Copy link
Collaborator

@shanemadden shanemadden commented Mar 9, 2024

To do:

  • Change to int repr and implement snippet-based conversion for Part
  • Change to int repr and implement snippet-based conversion for StructureType
  • Change to int repr and implement snippet-based conversion for ResourceType / IntershardResourceType / MarketResourceType
  • Change to int repr and implement snippet-based conversion for PowerCreepClass
  • Implement snippet-based conversion for ObjectId / RawObjectId
  • Implement snippet-based conversion for RoomName
  • Implement snippet-based conversion for Direction (when encountered in string form, eg. in describe_exits() return)
  • Add tests for all conversions including benchmarks if practical
  • Add wasm-pack test --node to GH actions test toolchain

Resolves #230

@shanemadden
Copy link
Collaborator Author

string enums have int reprs automatically in wasm-bindgen 0.2.93; no longer need some of this, but other parts will still be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More efficient (Raw)ObjectId loading
1 participant