Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.8.0 #92

Merged
merged 1 commit into from
May 3, 2024
Merged

Bump to 1.8.0 #92

merged 1 commit into from
May 3, 2024

Conversation

kylekthompson
Copy link
Member

@kylekthompson kylekthompson commented May 3, 2024

Prepare 1.8.0 release


ABQ 1.7.4 is a patch release.

This release fixes a typo in the specification of the RWX Cloud API, and a typo
in the configuration of certain logs.

# 1.7.3
## 1.7.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were at a different heading level than most versions

Comment on lines +128 to +134
guarantees across versions of ABQ queues are provided at this time.
`run_state` files are guaranteed to be compatible if shared between ABQ
queues of the same version.
If an ABQ queue loads a `run_state` file that it is incompatible with, the
remote test run state will not be loaded. Executing a test suite whose
run state file failed to be loaded will fall back on executing the test
suite as a fresh run, similar to the pre-1.4.0 behavior.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier decided to fix indentation of this

Comment on lines +211 to +215
- `<mode>` is either "store" or "load", depending on whether the file should be stored
into the remote location, or loaded from the remote location.
- `<file-type>` is either "manifest" or "results".
- `<run-id>` is the run ID of the test suite run.
- `<local-path>` is the path to the file on the local filesystem. If the mode is "store",
- `<file-type>` is either "manifest" or "results".
- `<run-id>` is the run ID of the test suite run.
- `<local-path>` is the path to the file on the local filesystem. If the mode is "store",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, prettier. Not sure if this one is correct or incorrect though \cc @ayazhafiz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the render and this seems good. I don't think we have prettier configured on this repo though maybe we should.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, sorry it's in my editor 😅 I didn't even realize it made these changes until I looked at the diff

@kylekthompson kylekthompson self-assigned this May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Bigtest for 7cc39cf (run)

Benchmarks:

  • RSpec: 11.83% overhead
    • RSpec time: 17.66 seconds
    • ABQ time: 19.75 seconds
  • RSpec parallel, 10 runs: max 12.97% overhead
    • min 5.95% overhead
    • standard deviation: 2.39%
  • Jest: 5.66% overhead
    • Jest time: 19.726 seconds
    • ABQ time: 20.842 seconds

Fuzz result sizes:

  • PASSED

@kylekthompson kylekthompson merged commit f26050c into main May 3, 2024
17 checks passed
@kylekthompson kylekthompson deleted the kt/new-version branch May 3, 2024 16:03
Copy link

github-actions bot commented May 3, 2024

Bigtest for f26050c (run)

Benchmarks:

  • RSpec: 13.47% overhead
    • RSpec time: 17.74 seconds
    • ABQ time: 20.13 seconds
  • RSpec parallel, 10 runs: max 13.3% overhead
    • min 6.26% overhead
    • standard deviation: 2.46%
  • Jest: 6.37% overhead
    • Jest time: 19.938 seconds
    • ABQ time: 21.209 seconds

Fuzz result sizes:

  • PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants