Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements #10

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Small improvements #10

merged 2 commits into from
Feb 8, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 7, 2024

  1. Remove an unused use (thanks, cargo fix)
  2. Use Vec::with_capacity() in convert_js_image_to_luma()

Thank you for the library!

Copy link
Collaborator

@hschimke hschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, approving.

@hschimke
Copy link
Collaborator

hschimke commented Feb 8, 2024

Thanks you for the PR, looks good to me, approved and merging. Will be included with the next release (alongside the next rxing release).

@hschimke hschimke merged commit 96540ce into rxing-core:main Feb 8, 2024
@akx akx deleted the improvements branch February 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants