Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix for Sphinx 3.4+ search #213

Merged
merged 3 commits into from
Jan 24, 2022
Merged

BUG: Fix for Sphinx 3.4+ search #213

merged 3 commits into from
Jan 24, 2022

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Jan 13, 2021 •
edited
Loading

Our version of readthedocs/sphinx_rtd_theme#1021 to fix issues due to sphinx-doc/sphinx#8623, i.e., search.html not actually searching due to Uncaught ReferenceError: Stemmer is not defined in Sphinx 3.4+.

Closes #214
Closes #220

@larsoner larsoner mentioned this pull request Jan 13, 2021
Closed
@jasmainak jasmainak mentioned this pull request Sep 21, 2021
Closed
lucag added a commit to lucag/sphinx-bootstrap-theme that referenced this pull request Oct 12, 2021
@lucag
Search Box not woking: Uncaught ReferenceError: Stemmer is not defined (
eacfaed 
ryan-roemer#213)
@ryan-roemer ryan-roemer mentioned this pull request Nov 29, 2021
Closed
@tanglef tanglef mentioned this pull request Dec 15, 2021
Closed
@tomMoral tomMoral mentioned this pull request Dec 16, 2021
Merged
@simonschmeisser
Copy link

friendly ping @larsoner @ivoire would be nice to have a new release with this fix included

@larsoner
Copy link
Contributor Author

CI errors appear to be of the form Error: Version 3.6 with arch x64 not found which perhaps makes sense since they are EOL. No idea why the 3.7+ variants got cancelled, though

@ivoire
Copy link
Contributor

ivoire commented Jan 24, 2022

@simonschmeisser I'm not maintainer of this package so I can't really help you. I'm also hoping for a patch to be merged and a new release to be made.

@simonschmeisser simonschmeisser mentioned this pull request Jan 24, 2022
Closed
@ryan-roemer
Copy link
Owner

@larsoner -- CI should now be fixed if you want to catch this PR up to current master. 🤞

@larsoner
Merge remote-tracking branch 'upstream/master' into language_data
eee46f6 
* upstream/master:
  CI: Update py3 matrix (ryan-roemer#222)
  setup.cfg: Replace dash-separated options (ryan-roemer#218)
  Bump to dev version post release
  Modern CI and Python Tooling (ryan-roemer#206)
@larsoner
Copy link
Contributor Author

Merged with upstream/master and it's all green now!

ryan-roemer
ryan-roemer approved these changes Jan 24, 2022
View reviewed changes
Copy link
Owner

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ryan-roemer ryan-roemer merged commit 0d80bff into ryan-roemer:master Jan 24, 2022
@larsoner larsoner deleted the language_data branch January 24, 2022 18:56
@ivoire ivoire mentioned this pull request Jan 25, 2022
Closed
@simonschmeisser
Copy link

Nice, now we just need a new release 🎉 (Sorry for being a bit pushy 😉

@ryan-roemer
Copy link
Owner

@simonschmeisser haha, no worries -- I was working on that the other day, but just got slammed at work. I'll try and get it out today / this week. (I'm doing the new test release workflow then doing our new full release).

@ryan-roemer
Copy link
Owner

Released in https://pypi.org/project/sphinx-bootstrap-theme/0.8.1/

And looks like the search now works, e.g. here: https://ryan-roemer.github.io/sphinx-bootstrap-theme/search.html?q=bootstrap

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoire ivoire ivoire left review comments

@ryan-roemer ryan-roemer ryan-roemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search doesn't work
4 participants
@larsoner @simonschmeisser @ivoire @ryan-roemer