-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version should declare dependency on markdown>=3.4 #38
Comments
corneliusroemer
added a commit
to corneliusroemer/sphinx-markdown-tables
that referenced
this issue
Jul 25, 2022
tsibley
added a commit
to nextstrain/sphinx-theme
that referenced
this issue
Jul 25, 2022
…d markdown packages" This reverts commit 88db52c. sphinx-markdown-tables 0.0.16 was released with a patch. Unfortunately its dependencies weren't updated too, so this workaround now actively breaks our docs builds because the newer sphinx-markdown-tables isn't compatible with the older markdown version declared here. See also <ryanfox/sphinx-markdown-tables#38>.
1 task
ryanfox
pushed a commit
that referenced
this issue
Jul 29, 2022
New version is available on PyPI. Thank you for the contribution. |
tsibley
added a commit
to nextstrain/cli
that referenced
this issue
Oct 4, 2022
See <ryanfox/sphinx-markdown-tables#38>. With the downgrade of Sphinx on 3.6 and 3.7 caused by "dev: Require flake8 ≥4.0.0" (352b8d7), this incorrect dep declaration was causing issues because Pip thought things were compatible when in reality the docs build didn't work on those Python versions.
tsibley
added a commit
to nextstrain/cli
that referenced
this issue
Oct 5, 2022
See <ryanfox/sphinx-markdown-tables#38>. With the downgrade of Sphinx on 3.6 and 3.7 caused by "dev: Require flake8 ≥4.0.0" (352b8d7), this incorrect dep declaration was causing issues because Pip thought things were compatible when in reality the docs build didn't work on those Python versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The dependency on
markdown
in setup.py:sphinx-markdown-tables/setup.py
Line 31 in 6450717
should be updated to
markdown>=3.4
to avoid runtime errors when an older version ofmarkdown
is installed.As it stands now, everyone who worked around #36 by pinning
markdown<3.4
now needs to revert that because now it ensures breakage. Folks likely wanted to revert those workarounds anyhow, but this incorrect dep issue also affects new installs ofsphinx-markdown-tables
where an oldermarkdown
is already installed, e.g.:The text was updated successfully, but these errors were encountered: