Hasklug ligature issue

[akosradler]

🎯 Subject of the issue

Experienced behavior:
Turning ligatures on for Hasklug turns || into a single line |
As these are separate operations in various languages, this behaviour is not desired. (and likely a bug)

🔧 Your Setup

• Tried with Hasklug Nerd Font Complete Mono Windows Compatible.otf
• Terminal agnostic
• Using Windows

[Finii]

Can reproduce:

== ligature works, || jumps to just one (right) bar on entering 2nd char

[Finii]

Somehow the rule is missing in the Mono font:

(E104 is the double-bar glyph)

Ah, yes, it is the old/dysfunctional attempt to remove ligatures from Nerd Font Mono fonts...

[Finii]

The code in font-patcher is wrong.

Original code (commit by Ryan 557fc00 ryanoasis 2016-03-18 23:15 -0400):

# let's deal with ligatures (mostly for monospaced fonts)
if args.configfile and config.read(args.configfile):
  if args.removeligatures:
    print("Removing ligatures from configfile `Subtables` section")
    ligature_subtables = json.loads(config.get("Subtables","ligatures"))
    for subtable in ligature_subtables:
      print("Removing subtable:", subtable)
      try:
        sourceFont.removeLookupSubtable(subtable)
        print("Successfully removed subtable:", subtable)
      except Exception:
        print("Failed to remove subtable:", subtable)
elif args.removeligatures:
  print("Unable to read configfile, unable to remove ligatures")
else:
  print("No configfile given, skipping configfile related actions")

That code has been touched once by Jimmy (commit 0a480bb Jimmy Haas 2018-08-04 03:39 -0700):

def remove_ligatures(self):
    # let's deal with ligatures (mostly for monospaced fonts)
    if self.args.configfile and self.config.read(self.args.configfile):
        if self.args.removeligatures:
            print("Removing ligatures from configfile `Subtables` section")
            ligature_subtables = json.loads(self.config.get("Subtables", "ligatures"))
            for subtable in ligature_subtables:
                print("Removing subtable:", subtable)
            try:
                self.sourceFont.removeLookupSubtable(subtable)
                print("Successfully removed subtable:", subtable)
            except Exception:
                print("Failed to remove subtable:", subtable)
        elif self.args.removeligatures:
            print("Unable to read configfile, unable to remove ligatures")
        else:
            print("No configfile given, skipping configfile related actions")

Note how the indentation changed ... now we have a loop that just prints ... :-(

The bottommost elif and else were also corrupted, but that has already been fixed with c72b0d9 `fracsinus 2021-07-26 06:24 +0900) with #644.

[Finii]

Fixed, thanks for reporting.

[akosradler]

Thank you for fixing it :)

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.