-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release master fontpatcher #1041
Conversation
I think something is wrong with the github actions thing I'm using to perform the release, but I know I've got the tag wrong anyway. Could I ask someone else to please fix that step in the workflow for me and then mark it as ready? |
But you do know that multiple people get an email for each commit you push, like ... every 10 minutes? I close this now here, please reopen when PR is ready. |
Oh no, I didn't realize this at all! Thanks for letting me know, I'm sure I've caused others this headache too... 🤢 |
Anyway, at this point I think I actually am done except that I do not know why it's not committing to my repository. It gets a 403 when I think I'm using the add-and-commit action the same way it's used in packsvgs, which confuses me. Could I ask you (or another maintainer) take a look at it and see if you can see what's wrong, and if there's anything else I need to change for it to be okay to merge, please? |
Thank you! That was it. I've now got a FontPatcher.zip in my relevant branch, committed and pushed by I'm gonna reread what you mentioned before about the scope, because I probably could improve that a bit. As it stands, it's Once I'm more confident it's all kosher I'll reopen the pull request (or open a new one, I'm not 100% certain if I can reopen one). |
Well, that is on You could limit it to 'push to master' (which is executed by explicit pushes to master as well as merging/ff-ing PRs to master). |
Description
Fixes #1040
@all-contributors please add @b- for infra
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)