CascadiaCode: Correct version string #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] With commit b6301e5 CascadiaCode: Rehint and use ttf we replaced the hints done upstream by ttfautohint with hints done via Visual TrueType, because they render the text more similar to the variable fonts (hints). But the version string still mentions 'ttfautohint' because we did not touch the font files at all except opening, hinting, closing in VTT. This can be confusing. [how] Change the version string to "Version 2111.001; VTT 6.35" via: * `ttx -i *.ttf` * Edit `ttx` files and replace version, see above * `ttx -b *.ttx` * Move new fonts over old fonts Signed-off-by: Fini Jastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
With commit
b6301e5
CascadiaCode: Rehint and use ttfwe replaced the hints done upstream by ttfautohint with hints done via Visual TrueType, because they render the text more similar to the variable fonts (hints).
But the version string still mentions 'ttfautohint' because we did not touch the font files at all except opening, hinting, closing in VTT. This can be confusing.
[how]
Change the version string to
"Version 2111.001; VTT 6.35"via:ttx -i *.ttfttxfiles and replace version, see abovettx -b *.ttxRequirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)