font-patcher: Preserve existing bitmaps #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why]
Bitmaps existing in a font are discarded. The font-patcher script just
cares about outline fonts.
[how]
If the sourcefont has bitmaps, do save them into the patched font. Note
that this does not generate bitmaps for the patched-in glyphs (icons).
[note]
Fonts probably affected in src/unpatched-fonts:
bitmap (11,) (gohufont-11)
bitmap (14,) (gohufont-14)
bitmap (11,) (gohufont-uni-11)
bitmap (14,) (gohufont-uni-14)
bitmap (7, 9, 10, 12, 14, 18, 24) (ProFontIIx)
bitmap (12, 14, 16, 18, 20, 22, 24, 28, 32) (TerminusTTF-Bold Italic-4.40.1)
bitmap (12, 14, 16, 18, 20, 22, 24, 28, 32) (TerminusTTF-Bold-4.40.1)
bitmap (12, 14, 16, 18, 20, 22, 24, 28, 32) (TerminusTTF-Italic-4.40.1)
bitmap (12, 14, 16, 18, 20, 22, 24, 28, 32) (TerminusTTF-4.40.1)
Fixes: #86
Reported-by: DoctorKnowsBetter
Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
bugfix/bitmap-fonts
branch
from
6945cac
to
6295b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
Bitmaps existing in a font are discarded. The font-patcher script just cares about outline fonts.
[how]
If the sourcefont has bitmaps, do save them into the patched font. Note that this does not generate bitmaps for the patched-in glyphs (icons).
[note]
Fonts probably affected in src/unpatched-fonts:
Fixes: #86
Reported-by: DoctorKnowsBetter
Requirements / Checklist
What does this Pull Request (PR) do?
Save the bitmaps existing in the source font into the patched font.
How should this be manually tested?
Take patched font and look for distortions as detailed in linked Issues.
Any background context you can provide?
[Note to self:] TTC support missing
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)