Update seti to current version #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From master branch, commit jesseweed/seti-ui@fd20793 Signed-off-by: Fini Jastrow <[email protected]>
Add "_nf" suffix to our own svgs. Add our icons database Adapt filename in icons database Just change the filenames of the custom icons to include the new "_nf" suffix. Signed-off-by: Fini Jastrow <[email protected]>
Some icons are now existing twice. * Their crystal icon looks wrong (rotationwise), compare with https://github.com/crystal-lang/crystal * Their C logo misses the standard's hex shape * Their C++ logo misses the standard's hex shape * Their Elixir icons has a dent in the reflextion? * Their Elm icon is colored * Their Git Folder is not a folder * Their Kotlin icon is colored * Their Puppet icon is more correct * Their Pursescript icon is identical * Their Windows icon is more modern That means: * Do not include their crystal, elixir, elm, kotlin, purescript * Do not include our puppet, windows * Keeping both c, c++, git-folder [note] Keeping their old files around with changed suffix to find this commit in the future on updates. Reuse old icons that were labeled as 'seti' but have been vanished as new custom types with appropriate file naming. And remove 'red' versions of icons. We have a black and white font... Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
Outline fonts are a bit picky about the embedded svgs. Best is if there is only one path. Ungrouped and path merged in Inkscape manually. Signed-off-by: Fini Jastrow <[email protected]>
[why] Some of the svgs still render incorrect in fontforge. [how] Different issues, for example wrong direction of the sub-path and still (forgotten?) multiple layers, etc. Manually tinker until they work. Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
This still had a path direction mismatch. Signed-off-by: Fini Jastrow <[email protected]>
$ ./optimize-original-source.sh doit
Checking for SVG simplifications
Files might be MODIFIED by this run ('doit' specified)
Found 177 svgs in ../../src/svgs
Simplification for ocaml.svg (5249 -> 3604) 68%
Simplification for apple.svg (3228 -> 2302) 71%
Simplification for pug.svg (5507 -> 4243) 77%
Simplification for jenkins.svg (13014 -> 6406) 49%
Simplification for firefox.svg (6276 -> 4640) 73%
Found 5 svgs to simplify
Signed-off-by: Fini Jastrow <[email protected]>
Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
feature/update-seti
branch
from
7bfc87e
to
7ffc6d9
Compare
|
Original table here: #365 (comment)
After the PR we go from |
The end codepoint needs to be shifted, now all new icons are patched in. Signed-off-by: Fini Jastrow <[email protected]>
This was referenced Jan 13, 2023
Closed
Closed
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
Update seti to current version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
They have added quite some more icons that people request/expect here also.
Unfortunately they seem to have no versioning anymore. So we update to this version
jesseweed/seti-ui@fd20793
Requirements / Checklist
What does this Pull Request (PR) do?
It adds a lot of new icons, existing/old ones are marked yellow in the following image.
The old codepoints are kept.
As they do not have stable codepoints that raises no additional issues for us (see here)
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)