-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#3 front design adjustment #36
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
基本的には LGTM です!
気になった点いくつかコメントしました!
あとは ReviewDog の怒られポイント解決できれば良いかと思います!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一点だけ気になった点追加しました!
import { useExhibitions } from "hooks/exhibitions/use-exhibitions"; | ||
import OGP from "@components/organisms/ogp"; | ||
import { firestoreExhibitionStore } from "store/exhibitions-store"; | ||
import { HomeFooter } from "@components/molecules/home/footer"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [tsc] <2307> reported by reviewdog 🐶
Cannot find module '@components/molecules/home/footer' or its corresponding type declarations.
Feature/Bug fix Pull Request
Description
Solution Description or how it was implemented
Testing / 動作確認
画面サイズを変更しながらフロントのデザインを軽く確認
ヘッダーの機能に問題がないか確認
Not yet solved / まだ解決していない物
InterのAのフォントがおかしい→解決済みヘッダーメニューの仕様上、ハンバーガーメニューの×の位置がおかしくなってしまう。(みりん先輩に相談しながら使用調整を行う)→解決済みOthers / その他