Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#3 front design adjustment #36

Merged
merged 27 commits into from
Aug 26, 2022

Conversation

takapan2
Copy link
Collaborator

@takapan2 takapan2 commented Aug 20, 2022

Feature/Bug fix Pull Request

Description

  • indexページにヘッダーメニューの追加
  • デザインの一部を修正
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Solution Description or how it was implemented

Testing / 動作確認

  • 画面サイズを変更しながらフロントのデザインを軽く確認

  • ヘッダーの機能に問題がないか確認

    • スクロール機能の付いたボタンが正しく動作するか確認

Not yet solved / まだ解決していない物

  • InterのAのフォントがおかしい →解決済み
  • ヘッダーメニューの仕様上、ハンバーガーメニューの×の位置がおかしくなってしまう。(みりん先輩に相談しながら使用調整を行う) →解決済み

Others / その他

@vercel
Copy link

vercel bot commented Aug 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
mirin-app-2022 ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:43PM (UTC)

@github-actions
Copy link
Contributor

@takapan2
Please labeling your issued PR !
And then, you should re-run pipeline by this link

components/molecules/header-menu.tsx Outdated Show resolved Hide resolved
components/molecules/header-menu.tsx Show resolved Hide resolved
components/molecules/header-menu.tsx Outdated Show resolved Hide resolved
components/molecules/header-menu.tsx Outdated Show resolved Hide resolved
components/molecules/header-menu.tsx Outdated Show resolved Hide resolved
components/organisms/home-layout.tsx Outdated Show resolved Hide resolved
components/organisms/home-layout.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@ryoctrl ryoctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基本的には LGTM です!
気になった点いくつかコメントしました!
あとは ReviewDog の怒られポイント解決できれば良いかと思います!

components/molecules/header-menu.tsx Outdated Show resolved Hide resolved
components/organisms/home-layout.tsx Outdated Show resolved Hide resolved
components/molecules/header-menu.tsx Show resolved Hide resolved
Copy link
Owner

@ryoctrl ryoctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点だけ気になった点追加しました!

components/molecules/header-menu.tsx Show resolved Hide resolved
import { useExhibitions } from "hooks/exhibitions/use-exhibitions";
import OGP from "@components/organisms/ogp";
import { firestoreExhibitionStore } from "store/exhibitions-store";
import { HomeFooter } from "@components/molecules/home/footer";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [tsc] <2307> reported by reviewdog 🐶
Cannot find module '@components/molecules/home/footer' or its corresponding type declarations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants