Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #10

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Fix build #10

merged 3 commits into from
Jun 26, 2019

Conversation

ryym
Copy link
Owner

@ryym ryym commented Jun 26, 2019

#9

  • Use gulp-babel@8 which is compatible for Babel 7
  • Use @babel/preset-env to simplify configuration
  • Modify task to check that CommonJS requireing works

(Now supported Node.js version is >= 8 so Babel may be unnecessary anymore..)

@coveralls
Copy link

Coverage Status

Coverage decreased (-44.8%) to 55.172% when pulling 63dfbbf on fix-build into fa6e03a on master.

@coveralls
Copy link

coveralls commented Jun 26, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 63dfbbf on fix-build into fa6e03a on master.

@ryym ryym merged commit 91f6d4c into master Jun 26, 2019
@ryym ryym deleted the fix-build branch June 26, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryym @coveralls