Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pypi / releases / tests #16

Closed
gitanat opened this issue Sep 9, 2016 · 2 comments
Closed

Pypi / releases / tests #16

gitanat opened this issue Sep 9, 2016 · 2 comments
Labels
enhancement New feature or bug fix question General discussion about the api or wrapper

Comments

@gitanat
Copy link

gitanat commented Sep 9, 2016

Hi s4w3d0ff,

This repository is pretty popular :)

Have you considered doing releases on pypi? Or releases in github? Is the code stable enough for general use? (I'm asking because I need a package to communicate with poloniex, and I'd like to depend on this to avoid reinventing the wheel or copy-pasting code).

Also, are unit tests planned / patches accepted?

Thanks!

@s4w3d0ff
Copy link
Owner

s4w3d0ff commented Sep 9, 2016

Hey @goncalopp,

I would love to see this repo released on pypi. I hadn't done so yet because (as you mentioned) it does need unit tests.

IMO the code is stable enough for a git release but I would feel better if the doc-strings were formatted/cleaned-up/updated before making a release to pypi.

I accept/welcome all sensible patches/improvements.

@s4w3d0ff s4w3d0ff closed this as completed Sep 9, 2016
@s4w3d0ff s4w3d0ff reopened this Sep 9, 2016
@s4w3d0ff s4w3d0ff added enhancement New feature or bug fix question General discussion about the api or wrapper labels Sep 9, 2016
s4w3d0ff pushed a commit that referenced this issue Sep 16, 2016
s4w3d0ff added a commit that referenced this issue Apr 13, 2017
@s4w3d0ff
Copy link
Owner

Well, since all most legit pypi package names have been trolled by dead code 🎉, I am not exactly interested in registering this repo. Everyone can just keep using pip install git+... unless a troll finds a heart and links this repo, I really don't care... sorry.
imgur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or bug fix question General discussion about the api or wrapper
Projects
None yet
Development

No branches or pull requests

2 participants