Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add limit parameter to returnTradeHistory #171

Merged
merged 2 commits into from
Dec 19, 2017
Merged

add limit parameter to returnTradeHistory #171

merged 2 commits into from
Dec 19, 2017

Conversation

skyl
Copy link
Contributor

@skyl skyl commented Nov 25, 2017

No description provided.

@s4w3d0ff
Copy link
Owner

Nice, thank you. I think the default should probably be False or None instead of the max. If Poloniex has a default I want to use that as our default, so it won't mess with people's code downstream.

@s4w3d0ff s4w3d0ff added the enhancement New feature or bug fix label Dec 18, 2017
@s4w3d0ff s4w3d0ff changed the base branch from master to dev December 19, 2017 00:58
@s4w3d0ff s4w3d0ff merged commit 96398e8 into s4w3d0ff:dev Dec 19, 2017
@ryanfalzon
Copy link

If you have 20,000 transactions to retrieve, and the maximum number you can retrieve with one call is 10,000, how do I get the other 10,000 if there is no offset parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyl @s4w3d0ff @ryanfalzon