v0.2.3 #50
Merged
v0.2.3 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdb424
approved these changes
Feb 10, 2017
|
I was also thinking of changing the argument names to match what polo has, example: 'fill_or_kill' should probably be 'fillOrKill' even tho it is not pep8... I personally have an easier time reading between the api docs and code if it is as close to the actual docs as possible. |
|
Considering the rest of your library doesn't follow full PEP8, I can see that as an acceptable change. |
s4w3d0ff
changed the title
|
We should have an 'orderType' argument for the advanced buy/sell/move orders instead of an argument for each type. It would reduce code and allow easier updates in the future if polo decides to add more. I'II make a commit to this branch with the changes tonight. |
makes it easy to add/remove new/old order types if poloniex decides to make more changes
a little bit better logging access, but not much...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the docs does not mention "fill or kill" for the move order, so i left it out