refactor: remove broker

[andreivladbrg]

Closes #1157

I also decided to rename the totalAmount parameter to depositAmount, as there was no other amount in the create function. I’m also considering removing the CreateEventCommon struct, as I believe we will no longer encounter the "Stack too deep" error, the only problem is that it will cause more changes to the app. @smol-ninja wdyt?

I'm surprised by how much this change reduces the code! This would be advantageous for integrators as well.

[smol-ninja]

I'm surprised by how much this change reduces the code

Yes I was not expecting it to reduce 800 lines. Clearly a good call to remove the broker fee.

I’m also considering removing the Lockup.CreateEventCommon struct

OK. Sounds good to me. I'd suggest to take the opinion of Razvan and Mircea on it though since it only affects the app.

[PaulRBerg]

cc @sablier-labs/frontend

[smol-ninja]

Great work on the PR @andreivladbrg. I have pushed a small commit (d62a8d4) just some natspec fixes and moved Base_Test.setUp() under TODO tag to signal it clearly that it needs to be removed later.

If all looks good, you can go ahead and merge it.

Re CreateEventCommon, can we do it in another PR and as a separate issue for easier review?

I have also not reviewed benchmarks dir since it will be removed in the future (#1170). I hope thats OK.

[andreivladbrg]

Re CreateEventCommon, can we do it in another PR and as a separate issue for easier review?

sounds good

I have also not reviewed benchmarks dir since it will be removed in the future (#1170). I hope thats OK.

that's ok, just keep in mind when you work on the new repo that there were made some changes in this branch

---

btw, pushed a commit to crease the coverage, don't know how we have missed it until now

[smol-ninja]

that's ok, just keep in mind when you work on the new repo that there were made some changes in this branch

Yes we both will be co-authors of those changes. Also, in the future PR, in case it requires making changes to the benchmark code, then lets just remove it (#1170).

btw, pushed a commit to crease the coverage, don't know how we have missed it until now

Good catch.