Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tox to 4.x #34840

Closed
mkoeppe opened this issue Dec 12, 2022 · 1 comment · Fixed by #36176
Closed

Upgrade tox to 4.x #34840

mkoeppe opened this issue Dec 12, 2022 · 1 comment · Fixed by #36176
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-10.2

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 12, 2022

Depends on #34839

Component: packages: standard

Branch: u/mkoeppe/upgrade_tox_4

Issue created by migration from https://trac.sagemath.org/ticket/34840
@mkoeppe mkoeppe added this to the sage-9.8 milestone Dec 12, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 12, 2022

Branch: u/mkoeppe/upgrade_tox_4

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Dec 31, 2022
kryzar pushed a commit to kryzar/sage that referenced this issue Feb 6, 2023
Trac sagemath#34849: More fixes to support tox 4
83b0cab 
The tox.ini files in pkgs/*/ are broken with tox 4.

Early versions of tox 4.x have additional defects.

- https://github.com/tox-
dev/tox/discussions/2699#discussioncomment-4403536 - factors no longer
work in `passenv` - fixed in tox 4.0.13

- negated factors in `deps`, like `!pipenv-!norequirements:
-rrequirements.txt` do not work - https://github.com/tox-
dev/tox/issues/2747 - fixed in tox 4.0.15

- And autoprovisioning for downgrade to tox 3 is not working -
tox-dev/tox#2634

- In SAGE_ROOT/tox.ini, in tox 4 earlier than 4.2.7, numerical factors
are broken because they are misinterpreted as Python versions
(https://tox.wiki/en/latest/changelog.html#bugfixes-4-2-7); e.g., 4.0.14
is broken:
  {{{
tox -e docker-linuxmint-21.1-standard
git:t/34903/tox_ini___gh_actions__update_linux_platforms*
docker-linuxmint-21.1-standard: skipped because could not find python
interpreter with spec(s): 21.1
  docker-linuxmint-21.1-standard: SKIP (1.98 seconds)
  }}}

Here we update affected `tox.ini` files so that:
- src/tox.ini and pkgs/*/tox.ini work both with suitable versions of tox
3 and tox 4. We change the tox `spkg-configure.m4` to check for such
versions.
- SAGE_ROOT/tox.ini work with tox >= 4.2.7 (autoprovisioning if
necessary)

Follow up:
- sagemath#34840 Upgrade tox to 4.x

URL: https://trac.sagemath.org/34849
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): Dima Pasechnik
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
@vbraun vbraun closed this as completed in 5b2f125 Sep 16, 2023
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging a pull request may close this issue.

build/pkgs/tox: Update, require tox >= 4.2.7, update dependencies mkoeppe/sage
1 participant
@mkoeppe