Add sizes whitelisting option #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagidM
requested changes
Feb 1, 2020
| /node_modules | ||
| .DS_Store |
There was a problem hiding this comment.
I would rather place OS-specific stuff into global ~/.gitignore.
In the end, there is no inner folder, can't see any discomforts of not having it ignored.
| /node_modules | ||
| .DS_Store | ||
| *.zip |
There was a problem hiding this comment.
When I make changes, I usually execute git commit -a or -am "...", adding all the edited files but not new ones.
For me, it is sufficient. Though yet I may understand the confusion of seeing zip files on git status afterward. So we can keep it.
| const options = parts[2].split('_'); | ||
| const filename = parts[3]; | ||
|
|
||
|
|
||
| const sizes = options[0].split("x"); | ||
| const action = options.length > 1 ? options[1] : null; | ||
|
|
||
| // Whitelist validation. | ||
| if (WHITELIST) { | ||
| const whitelistArr = WHITELIST.split(' '); |
There was a problem hiding this comment.
It would be better to avoid splitting on each request.
|
I am only interested in keeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #10.