Add configuration for vendor and commons chunk #417
Conversation
README.md
Outdated
| ```js | ||
| // sagui.config.js | ||
| module.exports = { | ||
| pages: ['index', { name: 'about', independent: true }] |
There was a problem hiding this comment.
Very small suggestion, but what about using a demo or playground in the name, to better hint this could be used for development pages.
There was a problem hiding this comment.
Makes sense. Will fix it.
README.md
Outdated
|
|
||
| #### `vendor` | ||
|
|
||
| If you want all your external dependencies in your [pages](#pages) to be bundled together in a "vendor" chunk, then set this flag to `true`. By default it is set to `false`. |
There was a problem hiding this comment.
...external dependencies (node_modules)...
src/configure-webpack/index.js
Outdated
| @@ -19,7 +19,7 @@ import buildLoadersConfig from './loaders' | |||
| * @return ready to use webpack configuration as an array | |||
| */ | |||
| export default (saguiConfig = {}) => { | |||
| const { pages = [], libraries = [], ...sharedSaguiConfig } = saguiConfig | |||
| const { pages = [], libraries = [], chunks = {}, ...sharedSaguiConfig } = saguiConfig | |||
There was a problem hiding this comment.
You shouldn't need to extract chunks here. Just let it in the sharedSaguiConfig.
Then, you can remove the extra parameter you've add (chunks) in a couple of places.
Makes sense?
| const common = plugins[1] | ||
|
|
||
| expect(vendor.selectedChunks[0]).equal('index') | ||
| expect(vendor.selectedChunks[2]).equal(undefined) |
There was a problem hiding this comment.
Maybe test the length of the selectedChunks here to be equal 1?
There was a problem hiding this comment.
For some reason there's an undefined on every other position in the array, so it will actually be 2. Will check that.
|
@pirelenito I'd appreciate your help with the integration tests. |
pirelenito
force-pushed
the
add-configuration-for-vendor-and-commons-chunk
branch
from
79ad537 to
5884302
Compare
There was a problem hiding this comment.
I've updated the PR with integration tests! Should be ready to merge and release!
Thanks a lot @Deschtex ❤️
Closes #415