Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to use unix "socketPath" for establish connection #11

Merged
merged 2 commits into from
Dec 28, 2018

Conversation

andrew-lyashenko
Copy link

Hi there!

Can you please accept my pull request to add ability to use "socketPath" option for mysql?

* commit 'f50689da650c8218301819c4f31703d9a658033b':
  3.0.1
  Update eslint
  3.0.0
  Follow-up to d9d31aa
  Update machine runner to v15. (refs balderdashy/sails#4264)

# Conflicts:
#	package.json
@mikermcneil
Copy link
Member

@andrew-lyashenko thanks! Would you mind writing up some sample usage? e.g. what would I put in my config/datastores.js file in order to use this?

Copy link
Member

@mikermcneil mikermcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-lyashenko
Copy link
Author

Yes, sure. Here is an example config:

config/datastores.js

default: {
    adapter: 'sails-mysql',
    user: 'db_user',
    password: 'db_password',
    database: 'db_name',
    socketPath: '/path/to/unix_socket'
}

@semy
Copy link

semy commented Jul 10, 2018

What is the status of this issue?

@mikermcneil
Copy link
Member

@semy @andrew-lyashenko Thanks for following up in Gitter y'all -- I set aside some time to review this weekend

@mikermcneil mikermcneil merged commit b3df079 into sailshq:master Dec 28, 2018
@mikermcneil
Copy link
Member

@semy @andrew-lyashenko thanks! I'll also get this change into https://github.com/mikermcneil/sails-sql -- I want to add some more configuration checks as well since mismatched db config is one of the most common thing folks new to the framework get confused about (e.g. can't specify both url and socketPath). Would welcome assistance on that front if y'all have a moment to take a look

@mikermcneil
Copy link
Member

mikermcneil added a commit to mikermcneil/sails-sql that referenced this pull request Dec 28, 2018
@mikermcneil mikermcneil self-assigned this Dec 30, 2018
mikermcneil added a commit to mikermcneil/sails-sql that referenced this pull request Jan 2, 2019
@mikermcneil
Copy link
Member

ok 👍 mikermcneil/sails-sql@f7c5b96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants