Thread generics throughout EuiBasicTable #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to type-check the props of EuiBasicTable and EuiInMemoryTable more effectively by making their props generic, and using the generic parameter throughout the tables' types.
9 tasks
chandlerprall
suggested changes
Oct 16, 2019
|
|
||
| interface Props { | ||
| action: Action; | ||
| export interface Props<T> { |
There was a problem hiding this comment.
I think we'd want the naming to be more specific than Props? Makes it easier to track in consuming files. (here & in the other files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to type-check the props of EuiBasicTable and
EuiInMemoryTable more effectively by making their props generic, and
using the generic parameter throughout the tables' types.