Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mobile appearance #240

Merged
merged 18 commits into from
Nov 20, 2019
Merged

Improve mobile appearance #240

merged 18 commits into from
Nov 20, 2019

Conversation

benekex2
Copy link
Contributor

@benekex2 benekex2 commented Nov 4, 2019

I want to merge this change because its fix general mobile issues

Ref #233

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@benekex2 benekex2 force-pushed the improve-mobile-appearance branch from fff41f2 to 42294af Compare November 4, 2019 21:08
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #240 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   73.97%   74.02%   +0.05%     
==========================================
  Files         604      605       +1     
  Lines        6481     6491      +10     
  Branches     1063     1063              
==========================================
+ Hits         4794     4805      +11     
  Misses       1501     1501              
+ Partials      186      185       -1
Impacted Files Coverage Δ
...rc/products/components/ProductList/ProductList.tsx 51.92% <ø> (ø) ⬆️
...nslationsEntitiesList/TranslationsEntitiesList.tsx 73.33% <ø> (ø) ⬆️
...mponents/DiscountCategories/DiscountCategories.tsx 82.6% <ø> (ø) ⬆️
...components/ShippingZonesList/ShippingZonesList.tsx 85% <ø> (ø) ⬆️
src/components/ColumnPicker/ColumnPicker.tsx 60% <ø> (ø) ⬆️
src/orders/components/OrderList/OrderList.tsx 92.59% <ø> (ø) ⬆️
...pes/components/ProductTypeList/ProductTypeList.tsx 95.65% <ø> (ø) ⬆️
...ts/AssignAttributeDialog/AssignAttributeDialog.tsx 90.9% <ø> (ø) ⬆️
...DraftDetailsProducts/OrderDraftDetailsProducts.tsx 84.21% <ø> (ø) ⬆️
...ountrySelectDialog/DiscountCountrySelectDialog.tsx 44.44% <ø> (ø) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e98cf1...5ce5ed0. Read the comment docs.

Copy link
Contributor

@dominik-zeglen dominik-zeglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Menu labels are hidden if menu is minimized in desktop mode:
Screenshot 2019-11-06 at 13 34 53

There's still too much going on:
Screenshot 2019-11-06 at 13 37 39

src/components/ResponsiveTable/ResponsiveTable.tsx Outdated Show resolved Hide resolved
src/components/ResponsiveTable/ResponsiveTable.tsx Outdated Show resolved Hide resolved
@dominik-zeglen dominik-zeglen force-pushed the improve-mobile-appearance branch from 42294af to 61b62da Compare November 12, 2019 16:30
@dominik-zeglen dominik-zeglen force-pushed the improve-mobile-appearance branch from 1ea7c75 to 5ce5ed0 Compare November 19, 2019 12:52
@maarcingebala maarcingebala merged commit 9b459f7 into master Nov 20, 2019
@maarcingebala maarcingebala deleted the improve-mobile-appearance branch January 9, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants