Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tax settings updating #243

Merged
merged 4 commits into from
Nov 7, 2019
Merged

Fix tax settings updating #243

merged 4 commits into from
Nov 7, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes inability to save taxes settings
Resolves #80

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   73.97%   73.97%           
=======================================
  Files         591      591           
  Lines        6195     6195           
  Branches     1040     1040           
=======================================
  Hits         4583     4583           
  Misses       1430     1430           
  Partials      182      182
Impacted Files Coverage Δ
src/components/SaveButtonBar/SaveButtonBar.tsx 69.23% <ø> (ø) ⬆️
src/storybook/stories/taxes/CountryListPage.tsx 57.14% <ø> (ø) ⬆️
...xes/components/CountryListPage/CountryListPage.tsx 90.9% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a56bb...32a58f4. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 4ed81f6 into master Nov 7, 2019
@dominik-zeglen dominik-zeglen deleted the fix/taxes branch November 7, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change the taxes settings
1 participant