Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update customer's details page design #248

Merged
merged 10 commits into from
Nov 15, 2019
Merged

Update customer's details page design #248

merged 10 commits into from
Nov 15, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it updates design of customer's details page.
Also increases font size in tables, which improves readability and keeps project in-date with the designs.

Resolves #84

Screenshots

Before:
Screenshot 2019-11-12 at 13 42 26

After:
Screenshot 2019-11-12 at 13 41 13

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #248 into master will decrease coverage by 0.04%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #248      +/-   ##
=========================================
- Coverage   74.14%   74.1%   -0.05%     
=========================================
  Files         600     601       +1     
  Lines        6451    6468      +17     
  Branches     1060    1061       +1     
=========================================
+ Hits         4783    4793      +10     
- Misses       1482    1489       +7     
  Partials      186     186
Impacted Files Coverage Δ
src/theme.ts 100% <ø> (ø) ⬆️
src/components/ControlledCheckbox.tsx 75% <ø> (ø) ⬆️
...onents/CustomerDetailsPage/CustomerDetailsPage.tsx 100% <ø> (ø) ⬆️
src/hooks/useAddressValidation.ts 44.44% <ø> (ø) ⬆️
src/components/CardTitle/CardTitle.tsx 100% <ø> (ø) ⬆️
src/misc.ts 54.54% <ø> (ø) ⬆️
...customers/components/CustomerInfo/CustomerInfo.tsx 100% <100%> (ø)
...ers/components/CustomerDetails/CustomerDetails.tsx 100% <100%> (ø) ⬆️
...mponents/CustomerCreatePage/CustomerCreatePage.tsx 63.15% <30%> (-36.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8170f9e...89b2958. Read the comment docs.

@maarcingebala
Copy link
Member

@dominik-zeglen The font size in tables in this PR is 16px in tables, while on the designs they're 14px.

@maarcingebala
Copy link
Member

image

When I fill only first name and last name in the address form an hit "Save":

Uncaught Error: Key  not found in enum
    at findInEnum (misc.ts?702e:328)
    at transformFormToAddress (misc.ts?702e:347)
    at onSubmit (CustomerCreate.tsx?94c4:92)
    at submit (useForm.ts?6329:128)
    at HTMLUnknownElement.callCallback (react-dom.development.js?61bb:336)
    at Object.invokeGuardedCallbackDev (react-dom.development.js?61bb:385)
    at invokeGuardedCallback (react-dom.development.js?61bb:440)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js?61bb:454)
    at executeDispatch (react-dom.development.js?61bb:584)
    at executeDispatchesInOrder (react-dom.development.js?61bb:609)

@maarcingebala maarcingebala merged commit 5024032 into master Nov 15, 2019
@maarcingebala maarcingebala deleted the fix/customers branch November 15, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI problems in "Create Customer" view
2 participants