Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Apollo Hooks #254

Merged
merged 8 commits into from
Nov 15, 2019
Merged

Use Apollo Hooks #254

merged 8 commits into from
Nov 15, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it simplifies a little bit code and makes diffs shorter.
Hooks are now used in catalog/categories section, but in future it's going to fully replace query components.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #254 into master will decrease coverage by 0.09%.
The diff coverage is 13.95%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #254     +/-   ##
=======================================
- Coverage    74.1%    74%   -0.1%     
=======================================
  Files         601    603      +2     
  Lines        6468   6464      -4     
  Branches     1061   1062      +1     
=======================================
- Hits         4793   4784      -9     
- Misses       1489   1494      +5     
  Partials      186    186
Impacted Files Coverage Δ
src/components/ErrorPage/ErrorPage.tsx 100% <ø> (ø) ⬆️
src/components/NotFoundPage/NotFoundPage.tsx 100% <ø> (ø) ⬆️
src/queries.tsx 6.06% <0%> (+0.34%) ⬆️
src/containers/AppState/reducer.ts 0% <0%> (ø)
src/hooks/useAppState.ts 0% <0%> (ø)
src/containers/AppState/state.ts 100% <100%> (ø)
src/containers/AppState/AppState.tsx 27.27% <27.27%> (ø)
src/products/utils/data.ts 83.87% <50%> (ø) ⬆️
...ers/components/CustomerDetails/CustomerDetails.tsx 100% <0%> (ø) ⬆️
src/components/CardTitle/CardTitle.tsx 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5024032...187415f. Read the comment docs.

@maarcingebala maarcingebala merged commit bb8af89 into master Nov 15, 2019
@maarcingebala maarcingebala deleted the ref/use-apollo-hooks branch November 15, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants