-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use searches as hooks instead of components #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdal
reviewed
Nov 20, 2019
dominik-zeglen
force-pushed
the
ref/hook-searches
branch
from
November 21, 2019 15:00
741fc9e
to
44ba4c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 74.02% 74.02% -0.01%
==========================================
Files 605 605
Lines 6491 6490 -1
Branches 1063 1063
==========================================
- Hits 4805 4804 -1
Misses 1501 1501
Partials 185 185
Continue to review full report at Codecov.
|
maarcingebala
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it simplifies code and prepares code to be navigator-ready.
Pull Request Checklist
.pot
file.