Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple images to be uploaded #277

Merged
merged 6 commits into from
Nov 29, 2019
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it resolves #241

Screenshots

Screenshot 2019-11-28 at 16 22 08

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@dominik-zeglen dominik-zeglen force-pushed the add/multiple-image-upload branch from a264b87 to 0239fa6 Compare November 28, 2019 15:28
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #277 into master will decrease coverage by 0.04%.
The diff coverage is 62.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   74.01%   73.96%   -0.05%     
==========================================
  Files         605      606       +1     
  Lines        6491     6519      +28     
  Branches     1064     1070       +6     
==========================================
+ Hits         4804     4822      +18     
- Misses       1501     1510       +9     
- Partials      186      187       +1
Impacted Files Coverage Δ
src/components/ImageUpload/ImageUpload.tsx 100% <ø> (+9.09%) ⬆️
...ons/components/CollectionImage/CollectionImage.tsx 86.66% <0%> (-6.2%) ⬇️
...mponents/CategoryBackground/CategoryBackground.tsx 85.71% <0%> (-6.6%) ⬇️
src/utils/handlers/multiFileUploadHandler.ts 100% <100%> (ø)
...roducts/components/ProductImages/ProductImages.tsx 63.33% <18.18%> (-21.67%) ⬇️
src/components/ImageTile/ImageTile.tsx 77.77% <50%> (-9.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c85800...81c5d37. Read the comment docs.

Copy link
Member

@maarcingebala maarcingebala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@maarcingebala maarcingebala merged commit 9e30bb7 into master Nov 29, 2019
@maarcingebala maarcingebala deleted the add/multiple-image-upload branch November 29, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow uploading multiple images at a time
2 participants